Skip to content

BUG: json_normalize not consistently ignoring errors (#41876) #42179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Jul 15, 2021
Merged

BUG: json_normalize not consistently ignoring errors (#41876) #42179

merged 11 commits into from
Jul 15, 2021

Conversation

neelmraman
Copy link
Contributor

@neelmraman neelmraman commented Jun 21, 2021 •
edited
Loading

@jbrockmendel
Copy link
Member

cc @WillAyd

@neelmraman
Copy link
Contributor Author

I'll be adding some unit tests as well

@neelmraman
Copy link
Contributor Author

@jbrockmendel @WillAyd mind kicking off the additional workflows/taking another look? thanks!

jreback
jreback requested changes Jun 25, 2021
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add a note in bug fixes, I/O section in 1.4 whatsnew

@jreback jreback added Bug IO JSON read_json, to_json, json_normalize labels Jun 25, 2021
@jreback jreback added this to the 1.4 milestone Jul 4, 2021
jreback
jreback requested changes Jul 4, 2021
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small comment, ping on green

@jreback
Copy link
Contributor

jreback commented Jul 4, 2021

also a conflict on the release notes

@neelmraman
Copy link
Contributor Author

@jreback should be good now!

@jreback jreback merged commit e271712 into pandas-dev:master Jul 15, 2021
@jreback
Copy link
Contributor

jreback commented Jul 15, 2021

thanks @neelmraman

feefladder pushed a commit to feefladder/pandas that referenced this pull request Sep 7, 2021
@neelmraman @feefladder
BUG: json_normalize not consistently ignoring errors (pandas-dev#41876)…
7aa5300 
… (pandas-dev#42179)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback approved these changes

Assignees
No one assigned
Labels
Bug IO JSON read_json, to_json, json_normalize
Projects
None yet
Milestone
1.4
Development

Successfully merging this pull request may close these issues.

BUG: seemingly unexpected behavior with errrors='ignore' in json_normalize()
3 participants
@neelmraman @jbrockmendel @jreback